Image Width and Height bugs found

Poster: tomistrugar
Dated: Wednesday October 15 2003 - 22:54:14 BST

Dear Milonic

I believe I have finally found the bugs that caused the problem I reported in my post http://www.milonic.com/forum/viewtopic.php?t=2573

On the Menu Items Quick Reference Guide it states that:

imageheight has code ref = 37
imagewidth has code ref = 38

This is correctly coded in milonic_src.js


However in mmenudom.js and mmenuns4.js the code refs have been switched. This is bug #1.

Additionally, in mmenudom.js and mmenuns4.js there is a typo:
the code

_Ihgt="";if(_I[38])_Ight=" height="+_I[38];

should read

_Ihgt="";if(_I[38])_Ihgt=" height="+_I[38];

i.e hgt instead of ght. This is bug #2.

Once I switched the code refs around in mmenudom.js and mmenuns4.js and corrected the typo, then my menu correctly coded BOTH the imageheight and the imagewidth.

Keep up the great work.

Tomi

Poster: Andy
Dated: Wednesday October 15 2003 - 23:02:26 BST

Well well well

What a star.

I only wish I could give certain people copies of the commented code, these things would be figured out in no time then.

Well found that man.

Cheers
Andy

Poster: John
Dated: Wednesday October 15 2003 - 23:06:06 BST

Great catch, Tomi. Most appreciated...

Poster: Maz
Dated: Thursday October 16 2003 - 0:25:13 BST

Thank you Tomi...
give the man a kiss *

I wonder how many that will fix on my menu,
maz

Hg=mercury... see I could have told you that, I've been told it will even mess with the precision of the atomic clock

Poster: Hergio
Dated: Thursday October 16 2003 - 3:48:08 BST

Wow very nice catch. I can't believe a typo/bug got past Andy!! You guys do understand this is his one slip up for the year, its not often you'll see something like this, so cherish it!

I am surprised it did not throw an error, eh Andy?

Poster: Andy
Dated: Thursday October 16 2003 - 9:47:47 BST

It's one of those bugs that won't generate an error because the variable does get set, it also creates a new (wrong) variable.

The goo variable doesn't get updated with the correct information though.

Very tricky to find enless you are looking for it.

-- Andy